Drop the test-only upload facade on MessageUrlImageHelper that
overwrote the shared HTTP client, move its tests to IpfsUploadHelper,
and build the multipart request with the final upload URI instead of
cloning it.
Only ';' needs encoding, so the title and body fit in one TXT string.
Values that aren't valid percent-encoding are used as-is instead of
hiding the banner.
The "get a node" banner's link, and optionally its title, body and button
text, now come from the _banner.meshcoreopen.org TXT record, looked up
over Cloudflare DNS-over-HTTPS and cached for the record's TTL (1 min to
6 h). The record is `v=1;on=1;url=<https link>` with URL-encoded values;
`on=0`, a missing record or any lookup failure hides the banner.
The firmware's CMD_ADD_UPDATE_CONTACT adds the key when it isn't in the
contact table. Screens that stay open after a contact is removed (e.g. a
repeater admin screen after the repeater's keys were changed and the old
contact deleted) sync the path before every send, so the next command,
status or telemetry request silently added the old contact back. Skip
path and flag writes for contacts no longer in the contact list.
removeContact now waits for the radio's reply and only drops the contact
locally when the radio confirms (or reports it doesn't have it), so a
lost command no longer leaves a contact that the next sync restores.
Failures are shown to the user. The delete dialog warns when the radio
auto-adds that contact type, since the contact returns on its next
advert.
The builder panel now labels its actions, lets the user pick round trip
or as-entered with an explanation, and only sends when "Run path trace"
is pressed. Hops, mode and the last result are kept in UiViewStateService
for the session, so going back no longer clears them and the last result
can be reopened without sending again.
Notification bodies now use the chat's parsers to show a localized
summary for shared locations (m: markers), channel images, GIFs and
reactions instead of the raw payload. The marker parser moves out of the
map screen into helpers/marker_message.dart so the service can use it.
Contacts now show the first path-hash-width bytes of their public key as
a monospace badge before the path label, so they can be matched to hops
in routing paths and told apart. The width follows the radio's path hash
size setting.
- Detect mentions on the original text, as @[name] or a whole-word @name
- Save and restore the full mode map in review mode
- Open the mode picker from the chat bell and show the mode in its tooltip
- Share one mode picker sheet; fix the stale sheet context
- Persist modes by name and skip unknown entries
- Keep writing muted_channels so older builds keep the user's mutes
- Remove the muteChannel/unmuteChannel/isChannelMuted shims
- Update notifications docs to match the behaviour
- Uploads carry a consent generation: nothing is sent if sharing is
turned off while a batch is being prepared, and a late response never
touches a queue that was cleared and refilled
- Parse only the signed 32 advert app-data bytes, as the firmware does,
so appended unsigned bytes can't add the hidden marker or change the
name
- Split online map requests that cross the antimeridian into two valid
boxes and merge the results
- README: link the network map next to the website
- Opt-in upload of header-only packet records and repeater/room server
adverts to map.meshcoreopen.org about once a minute; payloads, channel
and DM hashes and transport codes are stripped on the phone, locations
snapped to a ~2 km grid, install ID rotates daily
- One-time opt-in dialog on first radio connection; toggle and status in
App settings
- Local / Online / Both switch on the map screen with online repeater
hexagons, links, add-to-contacts and manage
- Node purchase banner on the connect screen (affiliate link, disclosed)
- Privacy policy and network map documentation
- Translations for all locales
- Image entries are stamped with their channel ID before the migration is
marked done, so an interrupted run repeats it instead of leaving them
unstamped (and invisible) forever.
- Channel message/data frames that arrive before this session's slot map
is confirmed are held and replayed once it is. Current firmware only
sends them in reply to SYNC_NEXT_MESSAGE, which already waits; this
guards against a stale saved map filing them under the wrong channel.
Channel messages, settings, region, order and images were persisted by
radio slot index, so a slot reused for a different channel inherited the
old channel's history and settings (#359).
- Channel.storageId: first 8 bytes of SHA-256("meshcore-channel:" + psk).
- All per-channel stores key by channel ID; in-memory state stays by slot.
- The connector keeps a slot -> channel ID map, diffs it against the saved
map on every channel sync and reloads slots whose channel changed.
- Queued channel frames wait until this session's map is confirmed.
- One-shot per-radio migration from slot keys, using the cached channel
list the legacy data was written under; rerun-safe if interrupted.
- Deleting a channel clears its data; a channel removed elsewhere keeps its
history and gets it back when re-added. A PSK edit keeps its place in
the custom order.
- Slots sharing a PSK share history and settings.
- Image entries record their channel ID; a slot change resets that slot's
in-progress reassembly.
- Extract reusable widgets (chat composer/send pipeline, message bubble
frame, reaction chips, path map scaffold, radio settings dialog,
translation settings section, map POI clusters, nav tiles, etc.) and
slim down the screens that used them
- Map: hide/remove markers with restore, confirm before setting node
location, POI clustering, semantics labels
- Map cache: cancellable downloads and a bulk tile limit
- Repeater: unsaved-changes guard, CLI search/copy/share transcript,
framed-command debug preview, disconnected banner
- Confirm before clearing chats and debug logs
- Keep cached unread totals in sync on per-contact/channel updates
- Move remaining hardcoded strings into l10n and translate the 98 new
keys into all 17 non-English locales
Merge dev (#588 share location, #436 discovered-contact import/export)
into fix/review-fixes-and-issue-batch. Conflicts: keep the node-scan
button alongside dev's import/export menu; take dev's marker label
prompt.
Share location (#588):
- Never share a missing or 0,0 radio position; hide the chat action and
show "Your radio has no location set"
- Sanitise marker labels ('|' -> '/', newlines -> spaces) on every path
- One shared MarkerLabelDialog owning its controller/focus node, with
keyboard submit, replacing three copies
- Map pins default to "Point of interest" again; "Share my location"
uses the node name
- Location shares honour the send cooldown and handle send errors
Discovered-contact import/export (#436):
- Per-entry decoding with imported/skipped/invalid counts; reject keys
that are not 32 bytes; skip in-file duplicates and the radio's own key
- Strip routing paths on import and stop exporting them; clamp future
timestamps; enforce the discovered-contact cap; require a connection;
2 MB file limit
- Export via in-memory XFile (fixes web); pass sharePositionOrigin for
iPad (also GPX export and image save); macOS user-selected read-write
entitlement for save dialogs
Docs: cover share location, import/export, node scan, TCP reconnect,
channel auto-resend options, arrival ordering, badge, password length
and image limits.
Translations for all new strings in every locale.
Outgoing image entries were excluded from the maxEntries cap, and age
eviction only marks them evicted, so frequent senders accumulated entries
and sidecars without bound. Outgoing entries with nothing left on disk (or
failed) are now eligible, oldest first.
Rename _ChannelChatRow.timestamp to receivedAt: it already returned the
local arrival time used for sorting and day separators.
Review fixes:
- Keep stored message history beyond the 200-message window; stop
messages leaking between radios; reset link/session state on disconnect
- Accept firmware's 176-byte RX frames over USB/TCP
- Hold APP_START during contact sync; contact-sync watchdog; replay DMs
from not-yet-known senders; tombstone late command replies; finish
channel sync on ERR_NOT_FOUND; fail region-scoped sends cleanly
- DM retry watchdog when RESP_CODE_SENT never arrives; late repeater CLI
replies; ACK hash collisions; UTF-8-safe name truncation
- Image pipeline: delete-during-decode, lifecycle cancels, decoder memory
release, entry cap, dead worker recovery, atomic model writes
- Storage: deterministic reaction hash across web/native, Smaz
double-decode, per-entry parsing, per-radio path history and regions,
review-mode data isolation
- UI: safe channel slot selection, byte-length name limits, double-send
guard, mounted checks, localized hardcoded strings
- Skip persisted-store reload on repeat SELF_INFO
Features:
- Radio default flood scope (firmware ver 11+) and explicit unscoped
sends (ver 12+)
- Scan for nearby nodes (#570)
- Optional distinct first-hop repeater counting for channel resend (#589)
- Optional region next to hop count (#580)
Issues:
- Message text follows system font size (#569)
- Repeater/room password field accepts 20 chars (#576)
- TCP auto-reconnect and keepalive (#571)
- Order feeds by local receive time; flag future timestamps (#584)
- Coding rate help text (#568), French "Favoris" (#575)
- iOS/macOS app badge now clears
Translations for all new strings in every locale.
- Default evictDiscoveredContactsEnabled to true so the 500-entry cap stays
in effect unless the user opts out
- Evict until under the cap when adding, so an oversized list recovers
- Pass the cap into the localized subtitle instead of hard-coding 500
- Fix German title and subtitle wording
- Save: block double taps, send radio config first, show an error if
persisting the setting fails
- Restore untranslated.json to match dev
Store reviewers have no MeshCore radio, so they could not reach any
screen past Connect or test the Android Auto messaging notifications.
- Long-press the "MeshCore Open" title on the Connect screen to enter
review mode on any platform
- A simulated radio speaks the companion protocol as a fourth transport,
so sync, messages, ACKs, notifications and notification replies run
through the normal code paths
- Seeded contacts, channels and history; a new incoming message every
45 s, auto-replies a few seconds after sending, and a banner with
"Send test message" and "Exit"
- Review data uses its own fixed key scope and is cleared on entry, exit
and at startup; the review scope never adopts legacy unscoped keys,
and channel mutes changed during review are restored
- Code lives in lib/review_mode/ with tests in test/review_mode/
- Message notifications use Android MessagingStyle with Reply, Mark as read,
and Mute channel actions, so they work in Android Auto and on watches
- Replies go through the normal send path (length limits, SMAZ, Cyr2Lat,
retries), split into up to 3 messages, and report failures
- Declare Android Auto notification support and register the action receiver
- Add a bell icon to channel chat to mute/unmute; unify the channel mute key
so unnamed channels mute correctly
- Update README and docs for Android Auto support
- Pass the existing contact's advert timestamp (0 for new contacts) so the
firmware replay guard does not drop the node's real adverts.
- Leave a missing/invalid QR type unset and fall back to the existing
contact's type instead of rewriting repeaters/rooms as Companion.
- Show a failed state with Retry instead of reopening the camera, which
rescanned the same QR and resent the frame in a loop.
- Keep the processing flag set after a successful import so the closing
route cannot restart the camera, import again and pop twice.
- Updated LoRa airtime calculations in `lora_airtime_test.dart` to reflect new reference values.
- Introduced new tests for LDRO behavior and preamble symbol calculations.
- Added `contact_path_width_test.dart` to validate path hash width handling in contacts.
- Enhanced `model_changes_test.dart` to ensure legacy data migration works correctly.
- Created `remote_node_stats_test.dart` to decode and validate remote node statistics.
- Implemented `map_marker_parse_test.dart` for parsing marker text with coordinate validation.
- Developed `map_tile_cache_key_test.dart` to ensure API keys are excluded from cache keys.
- Added `message_retry_failure_test.dart` to test message retry service behavior on failures.
- Extended `path_history_service_test.dart` to preserve learned state across path attempts.
- Enhanced `received_image_store_test.dart` to handle concurrent writes and review fixes.
- Implemented `repeater_command_service_test.dart` to validate command response handling.
- Created `store_tolerant_parsing_test.dart` to ensure stores skip malformed records gracefully.
- Cleared untranslated JSON file for localization updates.
flutter_test blocks real HTTP, so the two pyx tests could never pass in CI.
Inject an overridable http.Client and drive them with MockClient.
(cherry picked from commit fb032ef0ee)
Contacts could only be imported by pasting `meshcore://<hex advert>` from
the clipboard, so contact QR codes and links shared by the official app
(`meshcore://contact/add?name=...&public_key=...&type=...`) could not be
used at all.
Add a contact QR scanner screen, reachable from the contacts menu, that
scans with the camera or decodes a QR code from a photo in the gallery.
Both the official contact-card link and the existing hex advert form are
accepted; cards are applied with CMD_ADD_UPDATE_CONTACT and advert blobs
keep using CMD_IMPORT_CONTACT.
Fixes#529
Companion firmware (MeshCore commit 4a869163, 2025-12-30) replaces the
CLI frame timestamp with the companion node's RTC for TXT_TYPE_CLI_DATA,
so "clock sync" sets the repeater clock to the node RTC. Nodes with a
wrong RTC push repeater clocks years into the future; firmware cannot
set the clock backwards without clkreboot.
- RepeaterCommandService: translate "clock sync" to "time <phone epoch>"
before sending, matching official meshcore-cli behavior
- repeater login dialog: send "time <epoch>" for auto clock sync after
login (this path bypasses RepeaterCommandService)
- add unit tests for the command translation
Ref: https://github.com/zjs81/meshcore-open/issues/464
In #521, @Avi0n mentions they will be changing MeshCoreOne's reaction
format in the next release.
Here we add support for the new format, while retaining support for
the old format as "MC1Legacy".
There's some redundancy. My goal was not to maximize elegance, but
to facilitate easily tearing out support for the legacy format months
from now when we no longer care about it.
This has not been tested in the wild, as nothing is transmitting the
new format yet.
- Made Crockford-matching regex slighlty stricter (not allowing U)
- Match arbitrarily long multi-code-point joined emoji
- Added more validation checks for potential emoji, including that it's
a single grapheme
- Added more unit tests for emoji parsing
- For reactions whose targets we can't find, display MC1-style
reactions as normal messages. Continue old beavior of silently
dropping unmatched MC-Open reactions.
Part of PR #537
MeshCoreOne is a companion app that supports emoji reactions, using a
different message format than ours.
This commit adds support for parsing and displaying reactions received
in the MeshCoreOne format.
Their format is described here:
https://github.com/Avi0n/MeshCoreOne/blob/main/docs/Reactions.md
Here's an example:
👍@[entropy]
b3je6qf7
Major differences compared to MeshCore-Open's reaction messages:
- includes the emoji, rather than an index code
- includes the name of who sent the message it refers to
- the hash does not depend on the sender name