In #521, @Avi0n mentions they will be changing MeshCoreOne's reaction
format in the next release.
Here we add support for the new format, while retaining support for
the old format as "MC1Legacy".
There's some redundancy. My goal was not to maximize elegance, but
to facilitate easily tearing out support for the legacy format months
from now when we no longer care about it.
This has not been tested in the wild, as nothing is transmitting the
new format yet.
- Made Crockford-matching regex slighlty stricter (not allowing U)
- Match arbitrarily long multi-code-point joined emoji
- Added more validation checks for potential emoji, including that it's
a single grapheme
- Added more unit tests for emoji parsing
- For reactions whose targets we can't find, display MC1-style
reactions as normal messages. Continue old beavior of silently
dropping unmatched MC-Open reactions.
Part of PR #537
MeshCoreOne is a companion app that supports emoji reactions, using a
different message format than ours.
This commit adds support for parsing and displaying reactions received
in the MeshCoreOne format.
Their format is described here:
https://github.com/Avi0n/MeshCoreOne/blob/main/docs/Reactions.md
Here's an example:
👍@[entropy]
b3je6qf7
Major differences compared to MeshCore-Open's reaction messages:
- includes the emoji, rather than an index code
- includes the name of who sent the message it refers to
- the hash does not depend on the sender name
In meshcore_connector.dart,
Initialize _processedContactReactions in outgoing reactions for DMs
In channel_message_store.dart & message_store.dart,
Handle reaction lists properly to un-break message loading.
In channel chat screen, clicking a reaction emoji brings up a popup
listing the received emoji reactions and their senders.
Also fixes a bug that prevented displaying the count numbers on
reactions. Code existed to display counts for multiples, but the
deduplication failed to differentiate between senders and was tossing
them out.
There is still another preexisting bug, not fixed by this commit, that
over-counts sent reactions in rooms.