From 5fe3367aaa8a25da61bb2be368c41ab5cda35b14 Mon Sep 17 00:00:00 2001 From: TeTeHacko Date: Wed, 2 Sep 2026 18:19:40 +0200 Subject: [PATCH] fix(kiss): off-by-one v clampu delky jmena zarizeni Co-Authored-By: Claude Opus 5 (1M context) --- examples/kiss_modem/KissModem.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/examples/kiss_modem/KissModem.cpp b/examples/kiss_modem/KissModem.cpp index 34f40fd1..d1eade1c 100644 --- a/examples/kiss_modem/KissModem.cpp +++ b/examples/kiss_modem/KissModem.cpp @@ -730,7 +730,10 @@ void KissModem::handleGetDeviceName() { char buf[96]; int n = snprintf(buf, sizeof(buf), "%s %s", _board.getManufacturerName(), FIRMWARE_VERSION); if (n < 0) n = 0; - if (n > (int)sizeof(buf)) n = sizeof(buf); + // snprintf vraci delku BEZ koncove nuly, takze n == sizeof(buf) znamena + // "presne se to nevleslo". `n > sizeof(buf)` to propustilo a clampovalo na + // sizeof(buf), cimz na drat sla i ta koncova nula na buf[95]. + if (n >= (int)sizeof(buf)) n = (int)sizeof(buf) - 1; writeHardwareFrame(HW_RESP(HW_CMD_GET_DEVICE_NAME), (const uint8_t*)buf, n); }