CI pouštělo `pio test -e native -e native_kiss_modem`. Guardy v Packet::readFrom zamerne nemeni navratovou hodnotu -- odmitnou presne to, co upstream odmitne az po precteni -- takze pod `native` projdou i BEZ nich; rika to i hlavicka test_packet_readfrom.cpp. Slo je tedy odstranit a CI zustalo zelene. Overeno mutaci: po odstraneni tri guardu z Packet.cpp `native` porad PASSED, `native_asan` skonci rc=1 a binarka hlasi "heap-buffer-overflow ... src/Packet.cpp:93 in mesh::Packet::readFrom". Doplneno `-fno-sanitize-recover=all`: bez toho UBSan nalez jen VYPISE a test dobehne uspesne, takze z te poloviny sanitizeru byla ozdoba. A poznamka do ini o pasti v diagnostice: `pio test` u padu sanitizeru vypise jen "Program received signal SIGHUP" a ASAN report SPOLKNE -- necti z toho, ze sanitizer nic nenasel, spust binarku primo. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
37 lines
1.0 KiB
YAML
37 lines
1.0 KiB
YAML
name: Run Unit Tests
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
- master
|
|
pull_request:
|
|
workflow_dispatch:
|
|
|
|
jobs:
|
|
test:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
|
|
- name: Clone Repo
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Setup Build Environment
|
|
uses: ./.github/actions/setup-build-environment
|
|
|
|
- name: Run Unit Tests
|
|
# native_asan MUSI byt v seznamu. Bounds guardy v Packet::readFrom
|
|
# zamerne nemeni navratovou hodnotu (odmitnou presne to, co upstream
|
|
# odmitne az po precteni), takze pod `native` projdou i BEZ nich -- rika
|
|
# to i hlavicka test_packet_readfrom.cpp. Bez tohohle envu slo ty ctyri
|
|
# kontroly z Packet.cpp odstranit a CI zustalo zelene.
|
|
run: pio test -e native -e native_asan -e native_kiss_modem -vv
|
|
|
|
- name: Upload Test Results
|
|
# Upload test results even if the test step failed.
|
|
if: always()
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: test-results
|
|
path: .pio/build/native/
|