Commit Graph
266 Commits
Author SHA1 Message Date
zjs81 a0ed3cf69c Dedupe region candidates without the # prefix
floodScopeKeyForRegion treats `foo` and `#foo` as the same scope, so a
region listed both ways matched every packet twice and was always reported
as ambiguous. Also consider the default region when resolving.
2026-09-27 12:37:45 -07:00
zjs81 7134bac7f7 Merge remote-tracking branch 'origin/dev' into ez_display_region
# Conflicts:
#	lib/connector/meshcore_connector.dart
#	lib/models/channel_message.dart
#	lib/screens/channel_chat_screen.dart
2026-09-27 12:37:45 -07:00
zjs81 8076a48816 Merge remote-tracking branch 'origin/dev' into contacts-full-warning
# Conflicts:
#	lib/connector/meshcore_connector.dart
#	lib/connector/meshcore_protocol.dart
#	lib/screens/contacts_screen.dart
2026-09-27 12:16:35 -07:00
zjs81 8b8715cfda Merge remote-tracking branch 'origin/dev' into fix/usb-serial-nonblocking-close
# Conflicts:
#	pubspec.yaml
2026-09-27 11:50:25 -07:00
zjs81 5d7f922c58 Improve channel resend error handling and enhance message comparison logic 2026-09-27 11:35:55 -07:00
zjs81 0e8a8bd8c4 Add unit tests for ChannelMessage replies and update untranslated.json with new translations 2026-09-25 13:23:07 -07:00
Zach adabbd4b54 Update protocol comparison and review documentation with recent findings and fixes 2026-09-25 10:16:04 -07:00
Zach d74587c167 Refactor LoRa airtime tests and add new functionality
- Updated LoRa airtime calculations in `lora_airtime_test.dart` to reflect new reference values.
- Introduced new tests for LDRO behavior and preamble symbol calculations.
- Added `contact_path_width_test.dart` to validate path hash width handling in contacts.
- Enhanced `model_changes_test.dart` to ensure legacy data migration works correctly.
- Created `remote_node_stats_test.dart` to decode and validate remote node statistics.
- Implemented `map_marker_parse_test.dart` for parsing marker text with coordinate validation.
- Developed `map_tile_cache_key_test.dart` to ensure API keys are excluded from cache keys.
- Added `message_retry_failure_test.dart` to test message retry service behavior on failures.
- Extended `path_history_service_test.dart` to preserve learned state across path attempts.
- Enhanced `received_image_store_test.dart` to handle concurrent writes and review fixes.
- Implemented `repeater_command_service_test.dart` to validate command response handling.
- Created `store_tolerant_parsing_test.dart` to ensure stores skip malformed records gracefully.
- Cleared untranslated JSON file for localization updates.
2026-09-25 10:01:18 -07:00
ericz 20e01145e6 display Regions in received Messages and allow reply to same region. 2026-09-21 17:52:33 +02:00
zjs81 d5f54dfa11 Merge pull request #537 from sethoscope/mc1-reactions
Handle MeshCoreOne's emoji reactions
2026-09-20 23:12:41 -07:00
Gianluca Boiano 2910dc9f67 Apply dart format 2026-09-17 23:12:52 +02:00
Gianluca Boiano 1b5ebf6834 Honor manual disconnect and re-validate state after waiting
Sixth review round:

- disconnect(manual: true) joining an in-flight automatic teardown now
  still marks it manual (and cancels the reconnect timer / stops the
  background service), so a user-initiated disconnect can no longer be
  followed by an auto-reconnect scheduled by the teardown it joined.
- _shouldAutoReconnect is false once _disposed, so a teardown that
  outlives disposal cannot arm a timer that calls connect() on a disposed
  connector.
- connect()/connectUsb()/connectTcp() and UsbSerialService.connect()
  re-check the connection state after awaiting the in-flight teardown.
  The await is a suspension point, so two callers could previously pass
  the initial guard, resume together and both run the open sequence.
2026-09-17 23:05:43 +02:00
Gianluca Boiano fa9e9d18cd Suppress connector state publication after dispose
Fifth review round:

- MeshCoreConnector.dispose() sets _disposed, and _setState(),
  notifyListeners() and markNotifyDirty() no-op afterwards. A teardown
  started before disposal can still be running (the USB native close waits
  out the kernel's closing_wait off the UI isolate), and its tail would
  otherwise call notifyListeners() on a disposed ChangeNotifier.
- _handleSerialData() now only drops callbacks in the teardown states
  (disconnecting/disconnected) instead of everything that is not
  `connected`, so data arriving in the `connecting` window is still
  ingested and buffered by the frame decoder.
2026-09-13 15:42:34 +02:00
Gianluca Boiano fb7958a52e Serialize connects against the connector-level teardown
Fourth review round:

- UsbSerialService.connect() now waits for _activeDisconnect before it
  claims the `connecting` status, covering the Android USB-host path too;
  previously the wait sat inside the desktop branch, so an Android
  reconnect could still be overwritten by the old teardown.
- MeshCoreConnector.disconnect() is now a re-entrant-safe wrapper around
  _disconnectInternal() that publishes the teardown as _activeDisconnect,
  and connect()/connectUsb()/connectTcp() join it before starting. The
  transport-level guard alone could not prevent the connector's own
  teardown tail from setting the state back to `disconnected` after a new
  connection was up. Repeat disconnect() calls now join the in-flight
  teardown instead of returning early while it is still running.

flutter analyze clean; flutter test 570 passing, 2 pre-existing failures
in message_url_image_helper_test.dart (identical on a stashed tree);
flutter build linux --debug succeeds.
2026-09-13 15:33:44 +02:00
Seth Golub 9d3b4a40d9 Improvements to MeshCore-One emoji reaction processing
- Made Crockford-matching regex slighlty stricter (not allowing U)
- Match arbitrarily long multi-code-point joined emoji
- Added more validation checks for potential emoji, including that it's
  a single grapheme
- Added more unit tests for emoji parsing
- For reactions whose targets we can't find, display MC1-style
  reactions as normal messages. Continue old beavior of silently
  dropping unmatched MC-Open reactions.

Part of PR #537
2026-09-07 09:50:14 -07:00
ericz 99ef08332a Fix URL image preference scoping and cache behavior 2026-08-28 21:25:58 +02:00
zjs81 c8bd1edf0f Merge branch 'dev' into ez_image_urls 2026-08-25 13:47:49 -07:00
zjs81 e9b7e8132b Merge branch 'dev' into emoji-reation-report 2026-08-25 13:38:55 -07:00
ericz 6786c3348f update zjs81/dev 724696cd3c and fix image preview position. 2026-08-11 20:30:14 +02:00
Zach eee72b4c65 Add ability to send images over lora 2026-08-10 23:20:46 -07:00
ericz d920449cbb Add Contact and Channelsettings to explicitly enable Picture preview. 2026-08-10 22:21:10 +02:00
Seth Golub df560a2fbc Fix errors in new reaction processing
In meshcore_connector.dart,
Initialize _processedContactReactions in outgoing reactions for DMs

In channel_message_store.dart & message_store.dart,
Handle reaction lists properly to un-break message loading.
2026-08-09 22:01:26 -07:00
Seth Golub 76b34779cf Add emoji reaction report for channel chat, fix reaction deduping bug
In channel chat screen, clicking a reaction emoji brings up a popup
listing the received emoji reactions and their senders.

Also fixes a bug that prevented displaying the count numbers on
reactions. Code existed to display counts for multiples, but the
deduplication failed to differentiate between senders and was tossing
them out.

There is still another preexisting bug, not fixed by this commit, that
over-counts sent reactions in rooms.
2026-08-07 21:24:00 -07:00
Hacuchino-hash 966c5d74cc Warn when the node reports contact storage is full 2026-08-07 08:02:01 -05:00
Hacuchino-hash 3a9c14e946 Show connected node hardware and firmware in device info 2026-08-07 08:02:00 -05:00
PacoX a8cac76491 resolved conflict and update doc 2026-07-09 09:08:50 +02:00
Zach 71fa8c17a4 Add cap for discovered contacts to manage memory usage 2026-07-08 20:48:09 -07:00
ericz 5ef976b3b5 Add option for automatic zerohop adverts on posision change. 2026-06-23 18:19:22 +02:00
HDDen 6492058a04 Merge branch 'dev' into update-pacox-multibyte 2026-06-16 11:53:59 +03:00
zjs81 55da952bfd Merge remote-tracking branch 'origin/dev' into test-regions Also added fixes 2026-06-15 22:46:59 -07:00
HDDen d61eaaaff1 Merge branch 'dev' into update-pacox-multibyte 2026-06-14 01:12:49 +03:00
zjs81 760d8e1db3 Update localization files and improve path map UI
- Added new localization strings for Swedish, Ukrainian, and Chinese languages in app_sv.arb, app_uk.arb, and app_zh.arb respectively.
- Enhanced the path map UI in channel_message_path_screen.dart for better readability and interaction.
- Improved message retry logic in message_retry_service.dart to prevent double-pumping of queues.
- Bumped version number in pubspec.yaml to 9.5.0+13.
- Cleared untranslated strings in untranslated.json to reflect current localization status.
2026-06-13 01:58:42 -07:00
zjs81 5ea6b17b16 feat: enhance MeshCoreConnector with improved timeout calculation and path resolution; add PathHopResolver for better contact resolution 2026-06-13 00:36:45 -07:00
zjs81 3707acb124 Refactor code structure and remove redundant sections for improved readability and maintainability 2026-06-12 22:55:41 -07:00
HDDen 27695d372a Updated to last dev 2026-06-12 14:44:09 +03:00
HDDen d06a4c1861 Merge branch 'dev' into update-pacox-multibyte 2026-06-12 13:39:09 +03:00
Zach 6a31d304d3 feat: update license type to nonprofit and add jni to plugin lists; bump dependencies for flutter_local_notifications, package_info_plus, share_plus, flutter_blue_plus_platform_interface, and llamadart 2026-06-11 10:08:31 -07:00
zjs81 26fdf74d69 Refactor UI code for better readability and consistency
- Improved formatting of ListTile icons and text styles in settings_screen.dart, telemetry_screen.dart, usb_screen.dart, gif_picker.dart, path_editor_sheet.dart, repeater_login_dialog.dart, and room_login_dialog.dart for better readability.
- Consolidated TextStyle definitions into single lines where applicable.
- Updated notification_service.dart to enhance readability of notification ID assignment.
- Simplified function signatures in routing_sheet.dart for clarity.
- Cleaned up test assertions in usb_flow_test.dart for conciseness.
- Removed unused translations in untranslated.json to streamline localization files.
2026-06-11 00:28:13 -07:00
zjs81 cba1e5950c feat: add contact UI helpers and path editor for routing management
- Implemented contactTypeIcon and contactTypeColor functions for better UI representation of contact types.
- Created colorForName and firstCharacterOrEmoji functions to enhance contact display.
- Developed PathEditorSheet widget for managing contact paths with a user-friendly interface.
- Introduced RoutingSheet for managing contact routing modes and displaying path history.
- Added a script for generating proof of concept (PoC) payloads for clipboard contact import validation.
2026-06-11 00:07:12 -07:00
PacoX c46a5ffa2f Fix direct path override validation 2026-06-05 08:34:57 +02:00
HDDen 9d1251f21e Merge branch 'dev' into test-regions 2026-05-31 16:52:27 +03:00
HDDen 0ca96ce5b1 Regions discovery from nearby repeaters 2026-05-31 16:47:22 +03:00
HDDen 3fc038682c Merge commit 'refs/pull/379/head' of https://github.com/zjs81/meshcore-open into test-regions 2026-05-31 00:06:16 +03:00
PacoX 9e5b360f28 fix int conversion 2026-05-28 09:31:42 +02:00
PacoX 2e767730fd Merge branch 'dev' into dev 2026-05-28 08:51:23 +02:00
HDDen 61fb39b9f8 Multibyte: some path fixes
- Validate encoded path hop counts before saving or sending custom paths
- Fix multi-byte path reversal by reversing hops instead of raw bytes
- Decode raw log path lengths using packed path_len format
- Localize path hash mode options and optimize map anchor lookup
2026-05-28 03:17:08 +03:00
HDDen 9e18b99e9d Multibyte: fixed path trace repeater icon and potential bugs 2026-05-28 02:52:04 +03:00
HDDen 2e4f26d7cd Multibyte: fix map 2026-05-28 02:20:56 +03:00
PacoX 6e81fdfd46 add clamp for path length 2026-05-27 08:32:16 +02:00
PacoX 5d03f99040 fix tracepath 2026-05-26 20:12:27 +02:00