floodScopeKeyForRegion treats `foo` and `#foo` as the same scope, so a
region listed both ways matched every packet twice and was always reported
as ambiguous. Also consider the default region when resolving.
- Updated LoRa airtime calculations in `lora_airtime_test.dart` to reflect new reference values.
- Introduced new tests for LDRO behavior and preamble symbol calculations.
- Added `contact_path_width_test.dart` to validate path hash width handling in contacts.
- Enhanced `model_changes_test.dart` to ensure legacy data migration works correctly.
- Created `remote_node_stats_test.dart` to decode and validate remote node statistics.
- Implemented `map_marker_parse_test.dart` for parsing marker text with coordinate validation.
- Developed `map_tile_cache_key_test.dart` to ensure API keys are excluded from cache keys.
- Added `message_retry_failure_test.dart` to test message retry service behavior on failures.
- Extended `path_history_service_test.dart` to preserve learned state across path attempts.
- Enhanced `received_image_store_test.dart` to handle concurrent writes and review fixes.
- Implemented `repeater_command_service_test.dart` to validate command response handling.
- Created `store_tolerant_parsing_test.dart` to ensure stores skip malformed records gracefully.
- Cleared untranslated JSON file for localization updates.
Sixth review round:
- disconnect(manual: true) joining an in-flight automatic teardown now
still marks it manual (and cancels the reconnect timer / stops the
background service), so a user-initiated disconnect can no longer be
followed by an auto-reconnect scheduled by the teardown it joined.
- _shouldAutoReconnect is false once _disposed, so a teardown that
outlives disposal cannot arm a timer that calls connect() on a disposed
connector.
- connect()/connectUsb()/connectTcp() and UsbSerialService.connect()
re-check the connection state after awaiting the in-flight teardown.
The await is a suspension point, so two callers could previously pass
the initial guard, resume together and both run the open sequence.
Fifth review round:
- MeshCoreConnector.dispose() sets _disposed, and _setState(),
notifyListeners() and markNotifyDirty() no-op afterwards. A teardown
started before disposal can still be running (the USB native close waits
out the kernel's closing_wait off the UI isolate), and its tail would
otherwise call notifyListeners() on a disposed ChangeNotifier.
- _handleSerialData() now only drops callbacks in the teardown states
(disconnecting/disconnected) instead of everything that is not
`connected`, so data arriving in the `connecting` window is still
ingested and buffered by the frame decoder.
Fourth review round:
- UsbSerialService.connect() now waits for _activeDisconnect before it
claims the `connecting` status, covering the Android USB-host path too;
previously the wait sat inside the desktop branch, so an Android
reconnect could still be overwritten by the old teardown.
- MeshCoreConnector.disconnect() is now a re-entrant-safe wrapper around
_disconnectInternal() that publishes the teardown as _activeDisconnect,
and connect()/connectUsb()/connectTcp() join it before starting. The
transport-level guard alone could not prevent the connector's own
teardown tail from setting the state back to `disconnected` after a new
connection was up. Repeat disconnect() calls now join the in-flight
teardown instead of returning early while it is still running.
flutter analyze clean; flutter test 570 passing, 2 pre-existing failures
in message_url_image_helper_test.dart (identical on a stashed tree);
flutter build linux --debug succeeds.
- Made Crockford-matching regex slighlty stricter (not allowing U)
- Match arbitrarily long multi-code-point joined emoji
- Added more validation checks for potential emoji, including that it's
a single grapheme
- Added more unit tests for emoji parsing
- For reactions whose targets we can't find, display MC1-style
reactions as normal messages. Continue old beavior of silently
dropping unmatched MC-Open reactions.
Part of PR #537
In meshcore_connector.dart,
Initialize _processedContactReactions in outgoing reactions for DMs
In channel_message_store.dart & message_store.dart,
Handle reaction lists properly to un-break message loading.
In channel chat screen, clicking a reaction emoji brings up a popup
listing the received emoji reactions and their senders.
Also fixes a bug that prevented displaying the count numbers on
reactions. Code existed to display counts for multiples, but the
deduplication failed to differentiate between senders and was tossing
them out.
There is still another preexisting bug, not fixed by this commit, that
over-counts sent reactions in rooms.
- Added new localization strings for Swedish, Ukrainian, and Chinese languages in app_sv.arb, app_uk.arb, and app_zh.arb respectively.
- Enhanced the path map UI in channel_message_path_screen.dart for better readability and interaction.
- Improved message retry logic in message_retry_service.dart to prevent double-pumping of queues.
- Bumped version number in pubspec.yaml to 9.5.0+13.
- Cleared untranslated strings in untranslated.json to reflect current localization status.
- Improved formatting of ListTile icons and text styles in settings_screen.dart, telemetry_screen.dart, usb_screen.dart, gif_picker.dart, path_editor_sheet.dart, repeater_login_dialog.dart, and room_login_dialog.dart for better readability.
- Consolidated TextStyle definitions into single lines where applicable.
- Updated notification_service.dart to enhance readability of notification ID assignment.
- Simplified function signatures in routing_sheet.dart for clarity.
- Cleaned up test assertions in usb_flow_test.dart for conciseness.
- Removed unused translations in untranslated.json to streamline localization files.
- Implemented contactTypeIcon and contactTypeColor functions for better UI representation of contact types.
- Created colorForName and firstCharacterOrEmoji functions to enhance contact display.
- Developed PathEditorSheet widget for managing contact paths with a user-friendly interface.
- Introduced RoutingSheet for managing contact routing modes and displaying path history.
- Added a script for generating proof of concept (PoC) payloads for clipboard contact import validation.
- Validate encoded path hop counts before saving or sending custom paths
- Fix multi-byte path reversal by reversing hops instead of raw bytes
- Decode raw log path lengths using packed path_len format
- Localize path hash mode options and optimize map anchor lookup