fix(kiss): off-by-one v clampu delky jmena zarizeni

snprintf vraci delku BEZ koncove nuly, takze n == sizeof(buf) znamena "presne se
to nevleslo". `if (n > (int)sizeof(buf)) n = sizeof(buf);` to propustilo a
clampovalo na 96, takze u dost dlouheho vyrobce + verze sel na drat i terminator
z buf[95] -- odpoved HW_CMD_GET_DEVICE_NAME s koncovou nulou a tise urizlou verzi.

Spravne `n >= (int)sizeof(buf)` a clamp na sizeof(buf) - 1.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
tthandClaude Opus 5 committed 2026-09-02 18:19:40 +02:00
1 parent 3865b012cf
commit fae1828a5d
1 file changed
+4 -1
+4 -1
View File
@@ -730,7 +730,10 @@ void KissModem::handleGetDeviceName() {
char buf[96];
int n = snprintf(buf, sizeof(buf), "%s %s", _board.getManufacturerName(), FIRMWARE_VERSION);
if (n < 0) n = 0;
if (n > (int)sizeof(buf)) n = sizeof(buf);
// snprintf vraci delku BEZ koncove nuly, takze n == sizeof(buf) znamena
// "presne se to nevleslo". `n > sizeof(buf)` to propustilo a clampovalo na
// sizeof(buf), cimz na drat sla i ta koncova nula na buf[95].
if (n >= (int)sizeof(buf)) n = (int)sizeof(buf) - 1;
writeHardwareFrame(HW_RESP(HW_CMD_GET_DEVICE_NAME), (const uint8_t*)buf, n);
}