Store reviewers have no MeshCore radio, so they could not reach any
screen past Connect or test the Android Auto messaging notifications.
- Long-press the "MeshCore Open" title on the Connect screen to enter
review mode on any platform
- A simulated radio speaks the companion protocol as a fourth transport,
so sync, messages, ACKs, notifications and notification replies run
through the normal code paths
- Seeded contacts, channels and history; a new incoming message every
45 s, auto-replies a few seconds after sending, and a banner with
"Send test message" and "Exit"
- Review data uses its own fixed key scope and is cleared on entry, exit
and at startup; the review scope never adopts legacy unscoped keys,
and channel mutes changed during review are restored
- Code lives in lib/review_mode/ with tests in test/review_mode/
Fill in untranslated strings for the 17 non-English locales (notification
replies, region settings, channel min-hops, image messages, map clustering,
and more). untranslated.json is now empty.
- Message notifications use Android MessagingStyle with Reply, Mark as read,
and Mute channel actions, so they work in Android Auto and on watches
- Replies go through the normal send path (length limits, SMAZ, Cyr2Lat,
retries), split into up to 3 messages, and report failures
- Declare Android Auto notification support and register the action receiver
- Add a bell icon to channel chat to mute/unmute; unify the channel mute key
so unnamed channels mute correctly
- Update README and docs for Android Auto support
Documentation:
- Correct web transport support: USB via Web Serial in Chrome only; no
BLE or TCP in the browser.
- Fix region scope semantics, routing modes (Auto/Flood/Manual), the
156-byte DM limit, repeater CLI framing, the guessed-location algorithm,
radio stats contents and settings labels.
- Add regions, image messages, radio statistics and troubleshooting guides.
- Restore coding conventions, localization workflow, storage scoping and
transport entry points to CLAUDE.md/AGENTS.md; align build/CI commands.
- Replace the obsolete docs/BLE_PROTOCOL.md with a pointer to the
maintained protocol reference.
Dutch (nl):
- Translate the 79 missing strings and correct existing mistranslations,
typos and grammar (e.g. "Uitzoomen", "Handmatig", "Slowaaks", frequency
range 150-2500 MHz).
- Use consistent terminology and informal "je" throughout; keep mesh terms
such as repeater, node, flood, hop and advert in English.
Fixes#538
floodScopeKeyForRegion treats `foo` and `#foo` as the same scope, so a
region listed both ways matched every packet twice and was always reported
as ambiguous. Also consider the default region when resolving.
F-Droid shows the changelog matching the built versionCode (currently 16),
so 13.txt would never display. Summarize the user-facing changes merged
between 9.5.0+13 and 9.5.0+16.
- Run the metadata check only when metadata or the workflow change, with a
read-only token, pinned action SHAs and no persisted checkout credentials.
- Wrap description bullet lists in <ul> as requested for F-Droid.
- Drop MGRS and OTA firmware update claims the app does not support, and
mention USB/TCP alongside BLE in the intro.
- Cancel the self-request timeout when sendFrame throws, so a failed send
no longer shows a second timeout snackbar or reschedules auto-refresh twice.
- Do not wait for respCodeSent on self requests: none is sent for a local
request, so any that arrives belongs to another send and replaced the
5s self timeout.
- Disable the Radio Stats telemetry button while disconnected, matching
the Settings tile.
- Pass the existing contact's advert timestamp (0 for new contacts) so the
firmware replay guard does not drop the node's real adverts.
- Leave a missing/invalid QR type unset and fall back to the existing
contact's type instead of rewriting repeaters/rooms as Companion.
- Show a failed state with Retry instead of reopening the camera, which
rescanned the same QR and resent the frame in a loop.
- Keep the processing flag set after a successful import so the closing
route cannot restart the camera, import again and pop twice.
dispose() no longer relies on FlSerial.closePort() to free the I/O buffers:
it checks the buffers' first byte instead of their address, so it usually
leaked both. Close via fl_close and always free by address.
A native close still running in a helper isolate is invisible to a fresh
isolate after hot restart, so connect() could fl_free() a slot mid-close.
Track the in-flight close with a per-process temp marker and wait for it
(bounded to 45s) before resetting the slot table.
- Updated LoRa airtime calculations in `lora_airtime_test.dart` to reflect new reference values.
- Introduced new tests for LDRO behavior and preamble symbol calculations.
- Added `contact_path_width_test.dart` to validate path hash width handling in contacts.
- Enhanced `model_changes_test.dart` to ensure legacy data migration works correctly.
- Created `remote_node_stats_test.dart` to decode and validate remote node statistics.
- Implemented `map_marker_parse_test.dart` for parsing marker text with coordinate validation.
- Developed `map_tile_cache_key_test.dart` to ensure API keys are excluded from cache keys.
- Added `message_retry_failure_test.dart` to test message retry service behavior on failures.
- Extended `path_history_service_test.dart` to preserve learned state across path attempts.
- Enhanced `received_image_store_test.dart` to handle concurrent writes and review fixes.
- Implemented `repeater_command_service_test.dart` to validate command response handling.
- Created `store_tolerant_parsing_test.dart` to ensure stores skip malformed records gracefully.
- Cleared untranslated JSON file for localization updates.
flutter_test blocks real HTTP, so the two pyx tests could never pass in CI.
Inject an overridable http.Client and drive them with MockClient.
(cherry picked from commit fb032ef0ee)
flutter_test blocks real HTTP, so the two pyx tests could never pass in CI.
Inject an overridable http.Client and drive them with MockClient.
(cherry picked from commit fb032ef0ee)
Sixth review round:
- disconnect(manual: true) joining an in-flight automatic teardown now
still marks it manual (and cancels the reconnect timer / stops the
background service), so a user-initiated disconnect can no longer be
followed by an auto-reconnect scheduled by the teardown it joined.
- _shouldAutoReconnect is false once _disposed, so a teardown that
outlives disposal cannot arm a timer that calls connect() on a disposed
connector.
- connect()/connectUsb()/connectTcp() and UsbSerialService.connect()
re-check the connection state after awaiting the in-flight teardown.
The await is a suspension point, so two callers could previously pass
the initial guard, resume together and both run the open sequence.
share_plus cannot share files on desktop: the Linux implementation throws
UnimplementedError('Sharing files not supported on Linux') unconditionally
(share_plus_linux.dart:22), and Windows throws for builds older than
10.0.17763. exportGPX() swallowed that in its catch-all, so every GPX
export on Linux ended as gpxExportFailed with the file already written to
the documents directory and never cleaned up.
On desktop, write the file where the user asks via file_selector's
getSaveLocation() instead of routing it through the share sheet; a
dismissed dialog maps to gpxExportCancelled. Mobile keeps the share flow.
Verified on Linux with a standalone probe app: SharePlus.share with files
throws UnimplementedError, while getSaveLocation returns the chosen path
and the GPX file is written there.
Fifth review round:
- MeshCoreConnector.dispose() sets _disposed, and _setState(),
notifyListeners() and markNotifyDirty() no-op afterwards. A teardown
started before disposal can still be running (the USB native close waits
out the kernel's closing_wait off the UI isolate), and its tail would
otherwise call notifyListeners() on a disposed ChangeNotifier.
- _handleSerialData() now only drops callbacks in the teardown states
(disconnecting/disconnected) instead of everything that is not
`connected`, so data arriving in the `connecting` window is still
ingested and buffered by the frame decoder.
Fourth review round:
- UsbSerialService.connect() now waits for _activeDisconnect before it
claims the `connecting` status, covering the Android USB-host path too;
previously the wait sat inside the desktop branch, so an Android
reconnect could still be overwritten by the old teardown.
- MeshCoreConnector.disconnect() is now a re-entrant-safe wrapper around
_disconnectInternal() that publishes the teardown as _activeDisconnect,
and connect()/connectUsb()/connectTcp() join it before starting. The
transport-level guard alone could not prevent the connector's own
teardown tail from setting the state back to `disconnected` after a new
connection was up. Repeat disconnect() calls now join the in-flight
teardown instead of returning early while it is still running.
flutter analyze clean; flutter test 570 passing, 2 pre-existing failures
in message_url_image_helper_test.dart (identical on a stashed tree);
flutter build linux --debug succeeds.
Third review round:
- disconnect() is now a re-entrant-safe wrapper around _disconnectInternal()
whose future is held in _activeDisconnect for the entire teardown, not just
the native close. connect() and dispose() wait on that instead of
_pendingNativeClose, so a reconnect can no longer open a new port and then
have the tail of the old teardown mark it disconnected.
- dispose() closes on any live handle (flh >= 0) instead of only when
isOpen() reports `open`: flserial keeps a valid slot and a running
SerialThread in the I/O error state, which would otherwise have been
orphaned. A setDTR() failure no longer skips the close.
- _releaseSerialBuffers() takes alreadyFreed: closePort() frees both buffers
but leaves the pointer fields dangling, so after a successful synchronous
close the fields are only cleared, never freed a second time.
Builds: flutter build linux --debug succeeds (after patching the unrelated
glibc >= 2.42 / tinycthread once_flag clash in the flserial checkout).